Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Catalyst support #2065

Merged
merged 140 commits into from
Jun 1, 2020
Merged

[Feature] Catalyst support #2065

merged 140 commits into from
Jun 1, 2020

Conversation

annakocheshkova
Copy link

@annakocheshkova annakocheshkova commented May 20, 2020

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • [ ] Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

AB#79037

Related PRs or issues

#2063

@codecov-commenter

This comment has been minimized.

Anna Kocheshkova and others added 4 commits May 21, 2020 18:56
…talyst

# Conflicts:
#	Vendor/iOS/PLCrashReporter/include/CrashReporter.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashFeatureConfig.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashMacros.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReport.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportMachineInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportProcessInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportSignalInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportSystemInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReportThreadInfo.h
#	Vendor/iOS/PLCrashReporter/include/PLCrashReporter.h
#	Vendor/iOS/PLCrashReporter/libCrashReporter-iOS.a
#	Vendor/macOS/PLCrashReporter/include/CrashReporter.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashFeatureConfig.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashMacros.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReport.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportMachineInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportProcessInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportSignalInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportSystemInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReportThreadInfo.h
#	Vendor/macOS/PLCrashReporter/include/PLCrashReporter.h
#	Vendor/macOS/PLCrashReporter/libCrashReporter-MacOSX-Static.a
#	Vendor/tvOS/PLCrashReporter/include/CrashReporter.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashFeatureConfig.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashMacros.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReport.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportApplicationInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportBinaryImageInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportExceptionInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportMachExceptionInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportMachineInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportProcessInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportRegisterInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportSignalInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportStackFrameInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportSymbolInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportSystemInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReportThreadInfo.h
#	Vendor/tvOS/PLCrashReporter/include/PLCrashReporter.h
#	Vendor/tvOS/PLCrashReporter/libCrashReporter-tvOS.a
#	cgmanifest.json
@annakocheshkova annakocheshkova marked this pull request as ready for review May 21, 2020 17:00
AppCenterCrashes/AppCenterCrashes/MSCrashes.mm Outdated Show resolved Hide resolved
Config/Global.xcconfig Outdated Show resolved Hide resolved
Config/Global.xcconfig Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Ruslan Urmeev and others added 3 commits May 29, 2020 17:00
Co-authored-by: Ivan Matkov <v-ivmatk@microsoft.com>
Still need to be changed.
MatkovIvan
MatkovIvan previously approved these changes May 29, 2020
@iamclement iamclement closed this May 29, 2020
@iamclement iamclement reopened this May 29, 2020
Fix SDK name reporting on Mac Catalyst
MatkovIvan
MatkovIvan previously approved these changes Jun 1, 2020
CHANGELOG.md Outdated Show resolved Hide resolved

### App Center Analytics

* **[Feature]** Add support for Mac Catalyst.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need those duplicates

Jamminroot
Jamminroot previously approved these changes Jun 1, 2020
Copy link
Contributor

@Jamminroot Jamminroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from nitpicks I mentioned, lgtm

@MatkovIvan MatkovIvan dismissed stale reviews from Jamminroot and themself via 0a9516d June 1, 2020 16:17
@MatkovIvan MatkovIvan merged commit 1ff4957 into develop Jun 1, 2020
@MatkovIvan MatkovIvan deleted the feature/support-catalyst branch June 1, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants